-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add documentation about OpenXR render models #11014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add documentation about OpenXR render models #11014
Conversation
Note: CI failures are related to upstream changes not being merged. |
2ff45dc
to
8b4ffc0
Compare
Just rebased this, but need to update the image with the latest rename we did. One sec. |
8b4ffc0
to
ecae4f5
Compare
Ok, image has been updated :) |
this implementation can be found in | ||
`our hand tracking demo <https://github.com/godotengine/godot-demo-projects/tree/master/xr/openxr_hand_tracking_demo>`_. | ||
|
||
**Need to submit a PR to the hand tracking demo for this implementation once render models is merged** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was a PR for this created?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Owh thanks for the reminder, yes I have one ready, no I haven't submitted it yet because at the time it wasn't yet public :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to dot some i's and cross some t's, had forgotten I had this waiting in the wings, which is actually the demo project I used to create the sample code in this documentation:
godotengine/godot-demo-projects#1218
This will ensure that the render models related to this hand are properly | ||
shown and offset if our collision handler has altered the location. | ||
|
||
**Add video or animation to see this in practice** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another TODO!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I get for there being months between writing this and being able to publish it :P
Need to make a recording of my Flynn demo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in a short video of showing the hand being blocked by a wall in the flynn demo.
42f4e50
to
1987c8d
Compare
1987c8d
to
8aac142
Compare
Documentation in support of godotengine/godot#107388,
Probably needs some tweaking after this PR is merged.