Skip to content

Add documentation about OpenXR render models #11014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BastiaanOlij
Copy link
Contributor

Documentation in support of godotengine/godot#107388,
Probably needs some tweaking after this PR is merged.

@BastiaanOlij
Copy link
Contributor Author

Note: CI failures are related to upstream changes not being merged.

@AThousandShips AThousandShips added the waiting on PR merge PR's that can't be merged until an engine PR is merged first label Jun 11, 2025
@AThousandShips AThousandShips removed this from the 4.x milestone Jun 11, 2025
@skyace65 skyace65 removed the waiting on PR merge PR's that can't be merged until an engine PR is merged first label Jun 22, 2025
@skyace65 skyace65 added this to the 4.5 milestone Jun 22, 2025
@BastiaanOlij BastiaanOlij force-pushed the openxr_render_models_doc branch from 2ff45dc to 8b4ffc0 Compare June 23, 2025 07:36
@BastiaanOlij
Copy link
Contributor Author

Just rebased this, but need to update the image with the latest rename we did. One sec.

@BastiaanOlij BastiaanOlij force-pushed the openxr_render_models_doc branch from 8b4ffc0 to ecae4f5 Compare June 23, 2025 08:31
@BastiaanOlij
Copy link
Contributor Author

Ok, image has been updated :)

this implementation can be found in
`our hand tracking demo <https://github.com/godotengine/godot-demo-projects/tree/master/xr/openxr_hand_tracking_demo>`_.

**Need to submit a PR to the hand tracking demo for this implementation once render models is merged**
Copy link
Contributor

@dsnopek dsnopek Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was a PR for this created?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Owh thanks for the reminder, yes I have one ready, no I haven't submitted it yet because at the time it wasn't yet public :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to dot some i's and cross some t's, had forgotten I had this waiting in the wings, which is actually the demo project I used to create the sample code in this documentation:
godotengine/godot-demo-projects#1218

This will ensure that the render models related to this hand are properly
shown and offset if our collision handler has altered the location.

**Add video or animation to see this in practice**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another TODO!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I get for there being months between writing this and being able to publish it :P

Need to make a recording of my Flynn demo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in a short video of showing the hand being blocked by a wall in the flynn demo.

@BastiaanOlij BastiaanOlij force-pushed the openxr_render_models_doc branch 2 times, most recently from 42f4e50 to 1987c8d Compare June 24, 2025 01:11
@BastiaanOlij BastiaanOlij force-pushed the openxr_render_models_doc branch from 1987c8d to 8aac142 Compare June 24, 2025 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement topic:xr Related to XR documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants